Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unmount error #209

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Fix unmount error #209

merged 2 commits into from
Mar 5, 2024

Conversation

alanthai
Copy link
Contributor

@alanthai alanthai commented Mar 1, 2024

  • Separate out boltEmbed. The base one (not checkout/embed) is also used in Login
  • Comment out unmount() causing errors. Will fix in next PR when the embed script is fixed.

@@ -25,7 +25,7 @@ const { boltIgniteEnabled, isShopperLoggedIn: isBoltShopperLoggedIn } = window.B
}
await account.waitForBoltReady();

unmounts.forEach((unmount) => unmount && unmount());
// unmounts.forEach((unmount) => unmount && unmount());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a TODO here in case it's forgotten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixes now so I'll revert

@alanthai alanthai merged commit 5575f77 into master Mar 5, 2024
4 checks passed
@alanthai alanthai deleted the athai/fix-unmount-error branch March 5, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants